sql server update problem

Why when I update one row in the database, all the options are updated correctly, but the image of another row is edited.

For example, I edit ID number 1, the date is edited correctly, but the photo of row 3 of the database is changed. But there is no change in the photo of row 1

try {            Class.forName("com.microsoft.sqlserver.jdbc.SQLServerDriver");            String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123;encrypt=true;trustServerCertificate=true;loginTimeout=30";            Connection con = DriverManager.getConnection(url);            String query = "UPDATE  Test SET Dates=?,images=? where ID=" + TxtID.getText();            PreparedStatement pst = con.prepareStatement(query);            pst.setString(1, datePicker1.getDate());            pst.setBytes(2, person_image);            pst.executeUpdate();            JOptionPane.showMessageDialog(null, "Edit Sucessfully!");        } catch (Exception e) {            JOptionPane.showMessageDialog(null, e);        }

1. Class.forName() to load a database driver is obsolete. Get rid of it.

2. You have a hybrid Prepared Statement. That probably is part of your problem. And it can be used to create a SQL Injection Attack. Do this:
           String query = "UPDATE  Test SET Dates=?,images=? WHERE ID= ?";            PreparedStatement pst = con.prepareStatement(query);            pst.setString(1, datePicker1.getDate());            pst.setBytes(2, person_image);            pst.setString(3, TxtID.getText());            pst.executeUpdate(); Also note that it is not good practice to start the name of a variable (TxtID) with an uppercase letter.

I prefer not to use uppercase on names of database schema items such as table and column names, because some databases can get confused when that is done. SQL itself is case-insensitive, though, and I prefer the common convention of writing SQL command names and operational elements in all caps.

This is not my original code. For your better understanding I have created this code to find an answer for the solution of the problem faster and also this method did not solve my problem

Without seeing the actual values of the records in question, and an indication of how they did or did not change it'll be hard to track this down. Post that data, and the code you're now using after you made the change Tim suggested.

Swing likely has nothing to do with this.

this is my all code
class for jtable
package Clas.JTables; /** * * @author M.Soleymani */ public class Test_JTable {     private int ID;    private String Dates;    private byte[] Picture;      public Test_JTable(int ID, String Dates, byte[] image) {        this.ID = ID;        this.Dates = Dates;        this.Picture = image;                  }    public int getID() {        return ID;    }    public String getDates() {        return Dates;    }    public byte[] getImage() {        return Picture;    } }
The continuation of the code is in the next post

I'm suspicious of the byte array, since it's a mutable object. Is it possible that your code is using only a single byte array and putting a reference to that array in each instance of the Test_JTable object?

java form

package Basic; import Clas.JTables.Test_JTable; import com.sun.javafx.application.PlatformImpl; import java.awt.ComponentOrientation; import java.awt.Desktop; import java.awt.Dimension; import java.awt.Image; import java.awt.image.BufferedImage; import java.io.BufferedReader; import java.io.ByteArrayInputStream; import java.io.ByteArrayOutputStream; import java.io.File; import java.io.FileInputStream; import java.io.FileNotFoundException; import java.io.FileOutputStream; import java.io.FileReader; import java.io.IOException; import java.io.UnsupportedEncodingException; import java.sql.Connection; import java.sql.DriverManager; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; import java.util.ArrayList; import java.util.logging.Level; import java.util.logging.Logger; import javafx.stage.FileChooser; import javax.imageio.ImageIO; import javax.swing.ImageIcon; import javax.swing.JLabel; import javax.swing.JOptionPane; import javax.swing.SwingConstants; import javax.swing.table.DefaultTableCellRenderer; import javax.swing.table.DefaultTableModel; import org.apache.commons.codec.binary.Base64; public class Test extends javax.swing.JFrame {    public int NonQuery() {        try {            String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;encrypt=true;trustServerCertificate=true;loginTimeout=30";            Connection con = DriverManager.getConnection(url);            Statement st = con.createStatement();            ResultSet resultSet = st.executeQuery("select count(*) from Test");            while (resultSet.next()) {                lblall.setText(String.valueOf(resultSet.getInt(1)));            }            int m;            m = Integer.parseInt(lblall.getText()) / 10;            lblpage.setText(String.valueOf(m));        } catch (Exception ex) {            JOptionPane.showMessageDialog(null, ex.getMessage());        }        return 0;    }    public Test() {        initComponents();        lblStart.setText("0");        NonQuery();        show_Test_Last();    }    public ArrayList<Test_JTable> TestList() {        ArrayList<Test_JTable> TestsList = new ArrayList<>();        try {            String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;encrypt=true;trustServerCertificate=true;loginTimeout=30";            Connection con = DriverManager.getConnection(url);            String QuerySelect = "select id ,dates , images from test order by ID OFFSET " + lblStart.getText() + " ROWS FETCH NEXT 10 ROWS ONLY  ";            Statement st = con.createStatement();            ResultSet rs = st.executeQuery(QuerySelect);            Test_JTable Test;            while (rs.next()) {                Test = new Test_JTable(rs.getInt("id"), rs.getString("dates"), rs.getBytes("images"));                TestsList.add(Test);            }        } catch (Exception ex) {            Logger.getLogger(this.getName()).log(Level.SEVERE, null, ex);        }        return TestsList;    }    public void show_Test() {        ArrayList<Test_JTable> list = TestList();        DefaultTableModel model = (DefaultTableModel) datatable.getModel();        model.setRowCount(0);        Object[] row = new Object[3];        for (int i = 0; i < list.size(); i++) {            row[0] = list.get(i).getID();            row[1] = list.get(i).getDates();            row[2] = list.get(i).getImage();            model.addRow(row);        }    }    public ArrayList<Test_JTable> TestListLast() {        ArrayList<Test_JTable> TestsList = new ArrayList<>();        try {            String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;encrypt=true;trustServerCertificate=true;loginTimeout=30";            Connection con = DriverManager.getConnection(url);            String QuerySelect = "select TOP(10) id ,dates , images from test order by ID DESC ";            Statement st = con.createStatement();            ResultSet rs = st.executeQuery(QuerySelect);            Test_JTable Test;            while (rs.next()) {                Test = new Test_JTable(rs.getInt("id"), rs.getString("dates"), rs.getBytes("images"));                TestsList.add(Test);            }        } catch (Exception ex) {            Logger.getLogger(this.getName()).log(Level.SEVERE, null, ex);        }        return TestsList;    }    public void show_Test_Last() {        ArrayList<Test_JTable> list = TestListLast();        DefaultTableModel model = (DefaultTableModel) datatable.getModel();        model.setRowCount(0);        Object[] row = new Object[3];        for (int i = 0; i < list.size(); i++) {            row[0] = list.get(i).getID();            row[1] = list.get(i).getDates();            row[2] = list.get(i).getImage();            model.addRow(row);        }        int startpage = Integer.parseInt(lblall.getText()) - 10;        if (startpage >= 10) {            lblStart.setText(String.valueOf(startpage));        }    }  

public void empty() {        TxtPath.setText("");        lbl_img.setIcon(null);        NonQuery();        show_Test_Last();    }    private void btnsaveActionPerformed(java.awt.event.ActionEvent evt) {                                                try {            String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;encrypt=true;trustServerCertificate=true;loginTimeout=30";            Connection con = DriverManager.getConnection(url);            String query = "insert into test (dates,images) values (?,?)";            PreparedStatement pst = con.prepareStatement(query);            pst.setString(1, datePicker1.getDate());            pst.setBytes(2, person_image);            pst.executeUpdate();            JOptionPane.showMessageDialog(null, "Inserted Sucessfully!");            empty();            NonQuery();            show_Test_Last();        } catch (Exception e) {            JOptionPane.showMessageDialog(null, e);        }    }    private void btnemptyActionPerformed(java.awt.event.ActionEvent evt) {                                                empty();    }    private void btnbrowsActionPerformed(java.awt.event.ActionEvent evt) {                                                    person_image = null;        PlatformImpl.startup(() -> {            FileChooser fileChooser = new FileChooser();            fileChooser.setTitle("choose image");            fileChooser.getExtensionFilters().addAll(                    new FileChooser.ExtensionFilter("JPG Files", "*.jpg")            );            File selectedFile = fileChooser.showOpenDialog(null);            if (selectedFile != null) {                if (selectedFile.exists()) {                    System.out.println(selectedFile.getPath());                    filename = selectedFile.getPath();                    TxtPath.setText(filename);                    ImageIcon imageIcon = new ImageIcon(new ImageIcon(filename).getImage().getScaledInstance(lbl_img.getWidth(), lbl_img.getHeight(), Image.SCALE_SMOOTH));                    lbl_img.setIcon(imageIcon);                    try {                        File image = new File(filename);                        FileInputStream fis = new FileInputStream(image);                        ByteArrayOutputStream bos = new ByteArrayOutputStream();                        byte[] buf = new byte[1024];                        for (int readNum; (readNum = fis.read(buf)) != -1;) {                            bos.write(buf, 0, readNum);                        }                        person_image = bos.toByteArray();                    } catch (Exception e) {                        JOptionPane.showMessageDialog(null,                                e,                                "warning!",                                JOptionPane.WARNING_MESSAGE);                    }                }            }        });    }      private void btneditActionPerformed(java.awt.event.ActionEvent evt) {                                                        try {            String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;encrypt=true;trustServerCertificate=true;loginTimeout=30";            Connection con = DriverManager.getConnection(url);            String query = "update  test set dates=?,images=? where id=?";            PreparedStatement pst = con.prepareStatement(query);            pst.setString(1, datePicker1.getDate());            pst.setBytes(2, person_image);            pst.setString(3, TxtID.getText());            pst.executeUpdate();            DefaultTableModel model = (DefaultTableModel) datatable.getModel();            model.setRowCount(0);            JOptionPane.showMessageDialog(null, "Edit Sucessfully!");            NonQuery();            empty();            show_Test_Last();        } catch (Exception e) {            JOptionPane.showMessageDialog(null, e);        }    }        private void btndeleteActionPerformed(java.awt.event.ActionEvent evt) {                                                       if (datatable.getSelectedRow() == -1) {            JOptionPane.showMessageDialog(null,                    "pleas select a row",                    "warning!",                    JOptionPane.WARNING_MESSAGE);        } else {            int opt = JOptionPane.showConfirmDialog(null, "Are you sure?", "delete", JOptionPane.YES_NO_OPTION);            if (opt == 0) {                try {                    String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;encrypt=true;trustServerCertificate=true;loginTimeout=30";                    Connection con = DriverManager.getConnection(url);                    System.out.println(url);                    con = DriverManager.getConnection(url);                    String query = "DELETE FROM test where id=?";                    PreparedStatement pst = con.prepareStatement(query);                    pst.setString(1, TxtID.getText());                    pst.execute();                    lbl_error.setText("row" + TxtPath.getText() + "delete successful");                    DefaultTableModel model = (DefaultTableModel) datatable.getModel();                    model.setRowCount(0);                    NonQuery();                    show_Test_Last();                    empty();                    btnbrows.setRequestFocusEnabled(true);                    btnbrows.requestFocus();                } catch (Exception ex) {                    Logger.getLogger(this.getName()).log(Level.SEVERE, null, ex);                    JOptionPane.showMessageDialog(null, ex.getMessage());                }            }        }    }                                         }

   private void datatableMouseClicked(java.awt.event.MouseEvent evt) {                                              int i = datatable.getSelectedRow();        for (int j = 0; j < datatable.getColumnCount(); j++) {            String a = datatable.getColumnModel().getColumn(j).getHeaderValue().toString();            if (a == "ID") {                LblID.setText(datatable.getValueAt(i, j).toString());                TxtID.setText(datatable.getValueAt(i, j).toString());            }            if (a == "Path") {                if (datatable.getValueAt(i, j) != null) {                    TxtPath.setText(datatable.getValueAt(i, j).toString());                }            }            if (a == "Image") {                if (datatable.getValueAt(i, j) != null) {                    try {                        byte[] img = (TestList().get(i).getImage());                        ImageIcon imageIcon = new ImageIcon(new ImageIcon(img).getImage().getScaledInstance(lbl_img.getWidth(), lbl_img.getHeight(), Image.SCALE_SMOOTH));                        lbl_img.setIcon(imageIcon);                        ByteArrayInputStream inStreambj = new ByteArrayInputStream(img);                        BufferedImage newImage = ImageIO.read(inStreambj);                        ImageIO.write(newImage, "jpg", new File("image\\outputImage.jpg"));                    } catch (IOException ex) {                        Logger.getLogger(Test.class.getName()).log(Level.SEVERE, null, ex);                    }                }            }        }    }    public static void main(String args[]) {        try {            for (javax.swing.UIManager.LookAndFeelInfo info : javax.swing.UIManager.getInstalledLookAndFeels()) {                if ("Nimbus".equals(info.getName())) {                    javax.swing.UIManager.setLookAndFeel(info.getClassName());                    break;                }            }        } catch (ClassNotFoundException ex) {            java.util.logging.Logger.getLogger(Test.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);        } catch (InstantiationException ex) {            java.util.logging.Logger.getLogger(Test.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);        } catch (IllegalAccessException ex) {            java.util.logging.Logger.getLogger(Test.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);        } catch (javax.swing.UnsupportedLookAndFeelException ex) {            java.util.logging.Logger.getLogger(Test.class.getName()).log(java.util.logging.Level.SEVERE, null, ex);        }        java.awt.EventQueue.invokeLater(new Runnable() {            public void run() {                new Test().setVisible(true);            }        });    }    private javax.swing.JLabel LblID;    private javax.swing.JTextField TxtID;    private javax.swing.JTextField TxtPath;    private javax.swing.JButton btnbrows;    private javax.swing.JButton btndelete;    private javax.swing.JButton btnedit;    private javax.swing.JButton btnempty;    private javax.swing.JButton btnsave;    private javax.swing.JTable datatable;    private datePicker.DatePicker datePicker1;    private javax.swing.JLabel jLabel1;    private javax.swing.JScrollPane jScrollPane2;    private javax.swing.JScrollPane jScrollPane3;    private javax.swing.JTable jTable1;    private javax.swing.JLabel lblStart;    private javax.swing.JLabel lbl_error;    private javax.swing.JLabel lbl_img;    private javax.swing.JLabel lblall;    private javax.swing.JLabel lblpage;     String filename = null;    byte[] person_image = null;    Connection con;    Statement st;    ResultSet rs;   }

Now, even when I press the save button, the pictures of other lines in the database change, for example, when saving a new record, the pictures of the first record are replaced with the new record, and the new picture is saved in the first record in the database. The same problem exists when editing a record.
I think that if the problem was with the byte array, the photo of the same line of data should have been changed. Why should the photo of another record in the database be edited when I use save button?

ok sorry
my data base is sql server 2022
my table name is test
Its fields are:
id int auto increment not NULL
dates date allow NULL
images image allow NULL

maysam soleymani qorabaee wrote:Why when I update one row in the database, all the options are updated correctly, but the image of another row is edited.

For example, I edit ID number 1, the date is edited correctly, but the photo of row 3 of the database is changed. But there is no change in the photo of row 1

I was confused by this originally and I'm still confused. I think what's confusing me is that I don't understand the difference between "editing" and "updating" in your terminology.

When you update a row in the database... I think I understand that, I assume you are using an SQL UPDATE statement to do that. Am I right so far? But then you say an image from a different row is "edited". Well first of all I don't know whether you're talking about a row in the JTable or a row in the database table. And second, I don't know what you mean when you say the image is "edited". Does something on the screen change unexpectedly? Or is it something in the database which changes unexpectedly? Or am I totally misunderstanding "edited"?

You posted a lot of code, and sure, Swing code can be voluminous for a simple task, but if I don't know what is going wrong then I just give up looking at the code.

I just glanced at the code.
       Object[] row = new Object[3];        for (int i = 0; i < list.size(); i++) {            row[0] = list.get(i).getID();            row[1] = list.get(i).getDates();            row[2] = list.get(i).getImage();            model.addRow(row);        }I think this should be:
       for (int i = 0; i < list.size(); i++) {            Object[] row = new Object[3];            row[0] = list.get(i).getID();            row[1] = list.get(i).getDates();            row[2] = list.get(i).getImage();            model.addRow(row);        }otherwise you keep overwriting 'row'.

In the database, we use the update command to update or edit a row, and use the insert command to save or insert new row
In the above codes, when I use the insert command, a new row is added to the database
But the photo I have chosen for the new row is moved with the photo of one of the previous rows in database.
in other words, the new photo is inserted for the previous rows and the photo of the previous row is moved to the new row in sql server.
The same thing happens when updating a line in database.

that's mean the photos are moved randomly in the database when I use the save or edit button in the program

          row[2] = list.get(i).getImage();

I think my weak hypothesis is that "list.get(i).getImage()" always returns a reference to the same byte array.

I don't think the problem is the value of the byte array
Because the selected photo is correctly inserted in the database, but it is insert or update in the wrong row
Interestingly,when i use save or edit button the date value is inserted or updated correctly and in its place (in database). but image It moves with other lines

And the photo of the line where the photo is entered will be moved to the selected line. Now whether I use the save button or the edit button

Carey Brown wrote:I just glanced at the code.
       Object[] row = new Object[3];        for (int i = 0; i < list.size(); i++) {            row[0] = list.get(i).getID();            row[1] = list.get(i).getDates();            row[2] = list.get(i).getImage();            model.addRow(row);        }I think this should be:
       for (int i = 0; i < list.size(); i++) {            Object[] row = new Object[3];            row[0] = list.get(i).getID();            row[1] = list.get(i).getDates();            row[2] = list.get(i).getImage();            model.addRow(row);        }otherwise you keep overwriting 'row'.

This appears in 2 places and will display the wrong contents for the rows.

I edited this part of the code but it didn't fix the problem
Does anyone have a solution?

Is it possible that the problem is from the database library or the database itself?

maysam soleymani qorabaee wrote:Is it possible that the problem is from the database library or the database itself?

There's a useful rule in debugging: "It's your fault". Yes, occasionally you will get burned by a long-hidden bug in some well-tested system software. But normally it's your fault. Don't waste any time in looking for bugs in other people's code until you're sure it isn't your bug.

I would suggest you take that code and get rid of all of the Swing code. Just reduce it to some code in which you put some images into your database. When you have that working, encapsulate it in a method. Then put the Swing code back in and have it call that method. If the bug reappears, then (as I said) it's your fault but at least you have restricted the number of places you have to look for it.

In addition to Paul's suggestion about ripping out the GUI stuff, I would refactor your code so that all your database code is not intertwined with the rest of the business logic. For example:
import java.sql.Connection; import java.sql.DriverManager; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; import java.util.ArrayList; import java.util.Arrays; import java.util.List; public class Maysam { public Maysam() { // TODO Auto-generated constructor stub } } // '2' because I already had a 'Picture' class Picture2 { private int id; private String date; private byte[] image; public Picture2( int id, String date, byte[] image ) {       this.id = id;       this.date = date;       this.image = image;     } public Picture2( ResultSet rs ) throws SQLException { id = rs.getInt( "id" ); date = rs.getString( "dates" ); image = rs.getBytes( "images" ); } public int getId() { return id; } public String getDate() { return date; } public byte[] getImage() { return image; } public String toString() { if( image == null ) return String.format( "%4d  %10s  image:(null)", id, date ); return String.format( "%4d  %10s  image:%d  hash:%d", id, date, image.length, Arrays.hashCode( image ) ); } } class Db { private static final String URL =            "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;" +            "encrypt=true;trustServerCertificate=true;loginTimeout=30"; public static int countRecords() { String query = "SELECT COUNT(*) FROM Test"; int count = -1; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { if( rs.next() ) count = rs.getInt( 1 ); } catch( Exception ex ) { ex.printStackTrace(); } return count; } public static List<Picture2> getRecords() { List<Picture2> list = new ArrayList<>(); String query = "SELECT id, dates, images FROOM test ORDER BY id"; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { while( rs.next() ) list.add( new Picture2( rs ) ); } catch( Exception ex ) { ex.printStackTrace(); } return list; } public static List<Picture2> getRecords( int offset, int fetch ) { List<Picture2> list = new ArrayList<>(); String query = "SELECT id, dates, images FROOM test ORDER BY id OFFSET " +         offset + " ROWS FETCH NEXT " + fetch + " ROWS ONLY"; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { while( rs.next() ) list.add( new Picture2( rs ) ); } catch( Exception ex ) { ex.printStackTrace(); } return list; } public static List<Picture2> getTopRecordsDescending( int fetch ) { List<Picture2> list = new ArrayList<>(); String query = "SELECT TOP(" + fetch + ") id, dates, images FROOM test ORDER BY id DESC"; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { while( rs.next() ) list.add( new Picture2( rs ) ); } catch( Exception ex ) { ex.printStackTrace(); } return list; } public static void insert( Picture2 picture ) { String query = "INSERT INTO test (dates,images) VALUES (?,?)"; try( Connection con = DriverManager.getConnection( URL ); PreparedStatement pst = con.prepareStatement(query); ) { pst.setString( 1, picture.getDate() ); pst.setBytes( 2, picture.getImage() ); pst.executeUpdate(); } catch( Exception ex ) { ex.printStackTrace(); } } public static void update( Picture2 picture ) { String query = "UPDATE test SET dates=?,images=? WHERE id=?"; try( Connection con = DriverManager.getConnection( URL ); PreparedStatement pst = con.prepareStatement(query); ) { pst.setString( 1, picture.getDate() ); pst.setBytes( 2, picture.getImage() ); pst.setInt( 3, picture.getId() ); pst.executeUpdate(); } catch( Exception ex ) { ex.printStackTrace(); } } public static void delete( int id ) { String query = "DELETE FROM test WHERE id=?"; try( Connection con = DriverManager.getConnection( URL ); PreparedStatement pst = con.prepareStatement(query); ) { pst.setInt( 1, id ); pst.execute(); } catch( Exception ex ) { ex.printStackTrace(); } } }

This should be almost everything you need to run, the only thing that needs to be filled in is the "getImage(String fname)" method that returns a byte[] given a file name. For "Keyboard" see the link in my signature below for "KeyboardUtility".
import java.sql.Connection; import java.sql.DriverManager; import java.sql.PreparedStatement; import java.sql.ResultSet; import java.sql.SQLException; import java.sql.Statement; import java.util.ArrayList; import java.util.Arrays; import java.util.List; public class Maysam { private static final String MAIN_MENU = """ 1. show count 2. show all 3. show some 4. show last 5. insert 6. update 7. delete 0. exit Enter menu selection: """; public static void main( String[] args ) { try { new Maysam().run(); } catch( Exception e ) { e.printStackTrace(); } System.out.println( "Done." ); } private void run() throws Exception { int selection = -1; do { selection = Keyboard.promptIntRange( MAIN_MENU, 0, 7 ); switch( selection ) { case 1: showCount(); break; case 2: showAll(); break; case 3: int offset = Keyboard.promptInt( "Enter offset: " ); int fetch = Keyboard.promptInt( "Enter number of rows to fetch: " ); showSome( offset, fetch ); break; case 4: int fetch2 = Keyboard.promptInt( "Enter number of rows to fetch: " ); showLast( fetch2 ); break; case 5: String date = Keyboard.promptStringNotEmpty( "Enter date: " ); String fname = Keyboard.promptStringNotEmpty( "Enter file name: " ); byte[] image = getImage( fname ); Db.insert( new Picture2( 0, date, image ) ); break; case 6: int id = Keyboard.promptInt( "Enter id: " ); String date2 = Keyboard.promptStringNotEmpty( "Enter date: " ); String fname2 = Keyboard.promptStringNotEmpty( "Enter file name: " ); byte[] image2 = getImage( fname2 ); Db.update( new Picture2( id, date2, image2 ) ); break; case 7: int id2 = Keyboard.promptInt( "Enter id: " ); Db.delete( id2 ); break; } } while( selection != 0 ); } static byte[] getImage( String fname ) throws IOException { return Files.readAllBytes( Paths.get( fname ) ); } void showCount() { System.out.println( Db.countRecords() ); } void showAll() { for( Picture2 p : Db.getRecords() ) System.out.println( p ); } void showSome( int offset, int fetch ) { for( Picture2 p : Db.getRecords( offset, fetch ) ) System.out.println( p ); } void showLast( int fetch ) { for( Picture2 p : Db.getLastRecordsDescending( fetch ) ) System.out.println( p ); } } // '2' because I already had a 'Picture' class Picture2 { private int id; private String date; private byte[] image; public Picture2( int id, String date, byte[] image ) {       this.id = id;       this.date = date;       this.image = image;     } public Picture2( ResultSet rs ) throws SQLException { id = rs.getInt( "id" ); date = rs.getString( "dates" ); image = rs.getBytes( "images" ); } public int getId() { return id; } public String getDate() { return date; } public byte[] getImage() { return image; } public String toString() { if( image == null ) return String.format( "%4d  %10s  image:(null)", id, date ); return String.format( "%4d  %10s  image:%d  hash:%d", id, date, image.length, Arrays.hashCode( image ) ); } } class Db { private static final String URL =            "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;" +            "encrypt=true;trustServerCertificate=true;loginTimeout=30"; public static int countRecords() { String query = "SELECT COUNT(*) FROM Test"; int count = -1; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { if( rs.next() ) count = rs.getInt( 1 ); } catch( Exception ex ) { ex.printStackTrace(); } return count; } public static List<Picture2> getRecords() { List<Picture2> list = new ArrayList<>(); String query = "SELECT id, dates, images FROOM test ORDER BY id"; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { while( rs.next() ) list.add( new Picture2( rs ) ); } catch( Exception ex ) { ex.printStackTrace(); } return list; } public static List<Picture2> getRecords( int offset, int fetch ) { List<Picture2> list = new ArrayList<>(); String query = "SELECT id, dates, images FROOM test ORDER BY id OFFSET " +         offset + " ROWS FETCH NEXT " + fetch + " ROWS ONLY"; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { while( rs.next() ) list.add( new Picture2( rs ) ); } catch( Exception ex ) { ex.printStackTrace(); } return list; } public static List<Picture2> getLastRecordsDescending( int fetch ) { List<Picture2> list = new ArrayList<>(); String query = "SELECT TOP(" + fetch + ") id, dates, images FROOM test ORDER BY id DESC"; try( Connection con = DriverManager.getConnection( URL ); Statement st = con.createStatement(); ResultSet rs = st.executeQuery( query ); ) { while( rs.next() ) list.add( new Picture2( rs ) ); } catch( Exception ex ) { ex.printStackTrace(); } return list; } public static void insert( Picture2 picture ) { String query = "INSERT INTO test (dates,images) VALUES (?,?)"; try( Connection con = DriverManager.getConnection( URL ); PreparedStatement pst = con.prepareStatement(query); ) { pst.setString( 1, picture.getDate() ); pst.setBytes( 2, picture.getImage() ); pst.executeUpdate(); } catch( Exception ex ) { ex.printStackTrace(); } } public static void update( Picture2 picture ) { String query = "UPDATE test SET dates=?,images=? WHERE id=?"; try( Connection con = DriverManager.getConnection( URL ); PreparedStatement pst = con.prepareStatement(query); ) { pst.setString( 1, picture.getDate() ); pst.setBytes( 2, picture.getImage() ); pst.setInt( 3, picture.getId() ); pst.executeUpdate(); } catch( Exception ex ) { ex.printStackTrace(); } } public static void delete( int id ) { String query = "DELETE FROM test WHERE id=?"; try( Connection con = DriverManager.getConnection( URL ); PreparedStatement pst = con.prepareStatement(query); ) { pst.setInt( 1, id ); pst.execute(); } catch( Exception ex ) { ex.printStackTrace(); } } }

I noticed that when I call show_Test_Last(); after initComponents(); or saving or editing  the images are not displayed correctly
But when show_Test(); I call it after initComponents(); or registration or editing, the photos are displayed correctly
What is wrong with this code that after saving or editing or initComponents(); Does it ruin the photo!
public ArrayList<Test_JTable> TestListLast() {        ArrayList<Test_JTable> TestsList = new ArrayList<>();        try {            String url = "jdbc:sqlserver://SHA-HumanSrv-01:1433;DatabaseName=Human;user=sa;password=123456;encrypt=true;trustServerCertificate=true;loginTimeout=30";            Connection con = DriverManager.getConnection(url);            String QuerySelect = "select TOP(10) id ,dates , images from test order by ID DESC ";            Statement st = con.createStatement();            ResultSet rs = st.executeQuery(QuerySelect);            Test_JTable Test;            while (rs.next()) {                Test = new Test_JTable(rs.getInt("id"), rs.getString("dates"), rs.getBytes("images"));                TestsList.add(Test);            }        } catch (Exception ex) {            Logger.getLogger(this.getName()).log(Level.SEVERE, null, ex);        }        return TestsList;    }    public void show_Test_Last() {        ArrayList<Test_JTable> list = TestListLast();        DefaultTableModel model = (DefaultTableModel) datatable.getModel();        model.setRowCount(0);                for (int i = 0; i < list.size(); i++) {            Object[] row = new Object[3];            row[0] = list.get(i).getID();            row[1] = list.get(i).getDates();            row[2] = list.get(i).getImage();            model.addRow(row);        }        int startpage = Integer.parseInt(lblall.getText()) - 10;        if (startpage >= 10) {            lblStart.setText(String.valueOf(startpage));        }    }

I noticed that when I use order by ID DESC in my query, there is a problem in saving and editing the photo
Why do you think this happens?

I'm not familiar with the database you are using but you have
select TOP(10) id ,dates , images from test order by ID DESC;This is what I've seen on other DBs
select id ,dates , images from test order by ID DESC LIMIT 10;

How about a before and after screen shot of your table showing the problem data.

Carey Brown wrote:I'm not familiar with the database you are using but you have
select TOP(10) id ,dates , images from test order by ID DESC;This is what I've seen on other DBs
select id ,dates , images from test order by ID DESC LIMIT 10;

it's not working in sql server

Msg 102, Level 15, State 1, Line 3
Incorrect syntax near 'LIMIT'.

in sql server must use
select TOP(10) id ,dates , images from test  order by ID DESC

OK. Each DB is slightly different so no great surprise.

Have you thought of trying the non-GUI code I posted?

Carey Brown wrote:How about a before and after screen shot of your table showing the problem data.

Pay attention to the ID, date and photos carefully

All Image's
image 1
Image 2
Image 3
Image 4
Image 5
Image 6
Image 7

Carey Brown wrote:Have you thought of trying the non-GUI code I posted?

Yes, the problem still remains

Well, for one thing, it seems that when you select a row it is using the row number as the ID, not the ID lists  in the row number.

The code to populate the table is based off of TestListLast, e.g. reverse order. The code to select from the list is based off of TestList which is in ascending order.

Beddy for me.

Carey Brown wrote:Well, for one thing, it seems that when you select a row it is using the row number as the ID, not the ID lists  in the row number.

I thought the same at first, so I entered the ID number manually, but the problem was still not solved. I even printed the ID number or entered it in the text box to make sure, but the problem was not solved.

Carey Brown wrote:The code to populate the table is based off of TestListLast, e.g. reverse order. The code to select from the list is based off of TestList which is in ascending order.

Beddy for me.

That's exactly why I don't understand where the problem comes from

I tried to remove the order by ID DESC . and With the following code, display the data in the table from the last to the first
models.moveRow(0, 0, models.getRowCount() - 1);

And again, the photos were not displayed in their place
I am almost sure that the problem is with the table
But I don't know which part is the problem and how to fix it

maysam soleymani qorabaee wrote:

Carey Brown wrote:The code to populate the table is based off of TestListLast, e.g. reverse order. The code to select from the list is based off of TestList which is in ascending order.

That's exactly why I don't understand where the problem comes from

You are keeping a shadow copy of your table in a list. You are highlighting a row from the table but then using the data from the list which is not in the same order.

In fact you have two shadow copies, one in ascending order and one in descending order and you are not matching up which one you are using to which way the JTable is currently displayed.

I suggest ditching the shadow copies. You do need a list temporarily to load the database results into the table but that's it. After that, when you select a row, use the row cells for your parameters  (no list).